MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
188 stars 115 forks source link

feat: server events and dappid recovery #1044

Closed abretonc7s closed 1 month ago

abretonc7s commented 1 month ago

Explanation

Fixes events emission and missing dappId from extension.

References

Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (e8d3319) to head (7483611). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rvice/ConnectionManager/handleJoinChannelResult.ts 80.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1044 +/- ## ========================================== + Coverage 78.81% 79.03% +0.22% ========================================== Files 179 179 Lines 4120 4126 +6 Branches 1016 1019 +3 ========================================== + Hits 3247 3261 +14 + Misses 873 865 -8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud