Closed abretonc7s closed 1 month ago
Attention: Patch coverage is 0%
with 30 lines
in your changes missing coverage. Please review.
Project coverage is 78.55%. Comparing base (
e7c9409
) to head (056a950
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
...kages/sdk/src/provider/initializeMobileProvider.ts | 0.00% | 30 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Explanation
Since Async Key exchange, the mobile directly returns the account and chainId before the "with" method is processed which can potentially trigger an eth_getBalance on sdk_react. The sdk historically was waiting for the first rpc response to treat as response to connectWith which is why it could treat response to getBalance instead of the "with" method. This PR fixes this issue.
References
Fixes: https://consensyssoftware.atlassian.net/jira/software/projects/SDK/boards/711?selectedIssue=SDK-61&sprintStarted=true
Checklist