Closed elefantel closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.02%. Comparing base (
95a6a83
) to head (afe78b7
). Report is 14 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
The Socket.io server should be able to add all the additional info by automatically attaching them to all events with the same id
.
Tested this without the changes proposed in this PR, on local server and the data seems right. Had previously inspected analytics logs from network tab on the browser, which is before originator info is added on socket code.
Explanation
This PR adds originator info in the
sdk_rpc_request
analytics. This information is currently missing making it not possible to attributesdk_rpc_request_done
to the corresponding request.Currently the
sdk_rpc_request
analytics analytics looks like this:While the corresponding the
sdk_rpc_request_done
analytics analytics looks like this:Checklist