MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
163 stars 99 forks source link

[Mobile] Enable deeplink connection support in MetaMask mobile app #741

Open ezgi-cengiz opened 6 months ago

ezgi-cengiz commented 6 months ago

Description:

Upgrade the MetaMask Mobile app to handle deep link communications from iOS dapps. Enable the iOS MetaMask app to accept connections, exchange public keys, and communicate securely with dapps using deep link-based messages, enhancing the overall speed and reliability of transactions and interactions.

Task:

bearsworth commented 5 months ago

It would be hugely better if you guys move in the direction of deep links alone. I am a bit new to looking at the beta SDK, but the previous SDK had a lot of connection issues which were probably unnecessary. The app would sporadically lose connection and you'd have to keep restarting it.

andreahaku commented 5 months ago

It would be hugely better if you guys move in the direction of deep links alone. I am a bit new to looking at the beta SDK, but the previous SDK had a lot of connection issues which were probably unnecessary. The app would sporadically lose connection and you'd have to keep restarting it.

I suggest you to take a look at the latest version as a lot of improvements have been made lately in terms of stability. A deep link based communication is under development for iOS SDK and should be out soon. On Android iOS we already have a direct connection between the mobile dapp using it and the MM mobile app using IPC AIDL.

bearsworth commented 5 months ago

It would be hugely better if you guys move in the direction of deep links alone. I am a bit new to looking at the beta SDK, but the previous SDK had a lot of connection issues which were probably unnecessary. The app would sporadically lose connection and you'd have to keep restarting it.

I suggest you to take a look at the latest version as a lot of improvements have been made lately in terms of stability. A deep link based communication is under development for iOS SDK and should be out soon. On Android iOS we already have a direct connection between the mobile dapp using it and the MM mobile app using IPC AIDL.

Thanks for the response, I'm developing in react native so hoping iOS support comes fast please! You replied to one of my threads before, but I'm having a bit of issue with Metamask Demo with Expo React Native, there is an error it keeps throwing about storage. Could you help me out with that by chance? It's in your project as an expo demo example. I don't understand why it throws this error despite working in the background on a clean install.

andreahaku commented 5 months ago

It would be hugely better if you guys move in the direction of deep links alone. I am a bit new to looking at the beta SDK, but the previous SDK had a lot of connection issues which were probably unnecessary. The app would sporadically lose connection and you'd have to keep restarting it.

I suggest you to take a look at the latest version as a lot of improvements have been made lately in terms of stability. A deep link based communication is under development for iOS SDK and should be out soon. On Android iOS we already have a direct connection between the mobile dapp using it and the MM mobile app using IPC AIDL.

Thanks for the response, I'm developing in react native so hoping iOS support comes fast please! You replied to one of my threads before, but I'm having a bit of issue with Metamask Demo with Expo React Native, there is an error it keeps throwing about storage. Could you help me out with that by chance? It's in your project as an expo demo example. I don't understand why it throws this error despite working in the background on a clean install.

Please open an issue so that we can follow you better. In any case we have an expo demo in the examples folder that I suggest you to try first. Thanks

bearsworth commented 5 months ago

It would be hugely better if you guys move in the direction of deep links alone. I am a bit new to looking at the beta SDK, but the previous SDK had a lot of connection issues which were probably unnecessary. The app would sporadically lose connection and you'd have to keep restarting it.

I suggest you to take a look at the latest version as a lot of improvements have been made lately in terms of stability. A deep link based communication is under development for iOS SDK and should be out soon. On Android iOS we already have a direct connection between the mobile dapp using it and the MM mobile app using IPC AIDL.

Thanks for the response, I'm developing in react native so hoping iOS support comes fast please! You replied to one of my threads before, but I'm having a bit of issue with Metamask Demo with Expo React Native, there is an error it keeps throwing about storage. Could you help me out with that by chance? It's in your project as an expo demo example. I don't understand why it throws this error despite working in the background on a clean install.

Please open an issue so that we can follow you better. In any case we have an expo demo in the examples folder that I suggest you to try first. Thanks

I opened an issue and you actually responded to it. [Bug]: Expo react native demo throw storage error with DEMO example and no changes #771

It's #771 using the most recent expo demo which you linked. There is an issue I get where storage error is thrown. You replied once but never got back.

andreahaku commented 5 months ago

I opened an issue and you actually responded to it. [Bug]: Expo react native demo throw storage error with DEMO example and no changes #771

It's #771 using the most recent expo demo which you linked. There is an issue I get where storage error is thrown. You replied once but never got back.

Ok added back to our bug triage and we'll review this Monday and have someone work on it :) Thanks