MetaMask / metamask-sdk

The simplest yet most secure way to connect your blockchain-based applications to millions of MetaMask Wallet users.
https://metamask.io/sdk/
Other
188 stars 115 forks source link

feat: revert socket server changes #985

Closed abretonc7s closed 3 months ago

abretonc7s commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 54.80427% with 127 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (a65d852) to head (244c161). Report is 4 commits behind head on main.

Files Patch % Lines
...rvice/ConnectionManager/handleJoinChannelResult.ts 36.84% 24 Missing :warning:
...sdk-communication-layer/src/RemoteCommunication.ts 0.00% 22 Missing :warning:
...ication/MessageHandlers/handleWalletInitMessage.ts 12.50% 21 Missing :warning:
...kages/sdk/src/provider/initializeMobileProvider.ts 0.00% 12 Missing :warning:
...ices/RemoteCommunicationPostMessageStream/write.ts 64.70% 12 Missing :warning:
...oteConnection/ConnectionManager/startConnection.ts 44.44% 10 Missing :warning:
.../RemoteConnection/EventListeners/setupListeners.ts 11.11% 8 Missing :warning:
...SocketService/ConnectionManager/reconnectSocket.ts 75.00% 7 Missing :warning:
...ocketService/ConnectionManager/connectToChannel.ts 79.16% 5 Missing :warning:
packages/sdk/src/utils/base64.ts 44.44% 5 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #985 +/- ## ========================================== - Coverage 86.64% 80.60% -6.04% ========================================== Files 177 180 +3 Lines 3863 4037 +174 Branches 949 1007 +58 ========================================== - Hits 3347 3254 -93 - Misses 516 783 +267 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

christopherferreira9 commented 3 months ago

Bypassing CI as the code in this is the same as https://github.com/MetaMask/metamask-sdk/pull/986 which just got merged

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud