MetaMask / metamask-snaps-beta

Fork of MetaMask that supports plugins! Read the Wiki!
https://github.com/MetaMask/metamask-snaps-beta/wiki
MIT License
142 stars 57 forks source link

Restructure plugin permissioning once the permissions system supports events and object APIs #141

Closed rekmarks closed 2 years ago

rekmarks commented 4 years ago

Plugins have and will continue to have permitted access to categories of things that rpc-cap was not designed to handle, e.g. events, object APIs (global or otherwise) etc. For example, see how we handle listeners for internal MetaMask events, see: https://github.com/MetaMask/metamask-snaps-beta/commit/679c9251b82f63d4d75ee399bb0f5d00d0ec16da

rpc-cap (or something else entirely) needs to add first-class support for object APIs using capnode or membranes. Until that extensive rewrite is done, we are stuck fitting a round peg in a square hole.

Related: #139

rekmarks commented 2 years ago

No longer relevant.