search

MetaMask / metamask-snaps-beta

Fork of MetaMask that supports plugins! Read the Wiki!
https://github.com/MetaMask/metamask-snaps-beta/wiki
MIT License
144 stars 57 forks source link

Minor grammar change #169

Closed actuallymentor closed 3 years ago

actuallymentor commented 3 years ago

Some of these workings sounds like an AI or Belgian person did them. I added less awkward Dutch phrasings.

The word gekopieerde is an adverb, in the UI it is used as a verb and should thus be gekopieerd.

The word vrij means free, but in line 3, line 6 context you strictly need blootleggen, roughlyto lay bare. The use ofweergevenonline 9` however is more is less unnatural (blootleggen sounds like "would you like to lay bare your accounts to this website").

Aangepaste doesn't mean custom but rather 'edited'. I used 'handmatig' which means 'manual'. It is the closest word in Dutch I can think of.

one-stop-bestemming is not a thing. I used 'all in one store'.

Changed some smaller grammatical issues as well.

Questions

[ ] Is "Hier is een lijst !!!!" intentional? [ ] Should PRs be against master or stable?

rekmarks commented 3 years ago

Hi @actuallymentor, thanks for creating this PR!

This should be made more clear in the readme, but this PR should be made against the main metamask-extension repository: https://github.com/MetaMask/metamask-extension/pulls

I'm going to go ahead and close this, but please do open a PR against the main repo if the changes are still relevant there.

actuallymentor commented 3 years ago

Done. See new PR