mcmire
commented
7 months ago Note that there are other Jest-related considerations that we could address in this PR but do not need to:
- The module template also has
@metamask/eslint-config-jestandeslint-plugin-jestas dev dependencies. We are already checking these as a part of #9, but if we want to make those checks more explicit we could split them into a separate rule that's tied more closely to the rules here. We could settle that in another PR, though. (Update: We decided to do this in a generic way, so we're not explicitly checking that these are present, yet. So we'd still need to do that.) - The module template also has
@types/jestandts-jestas dev dependencies. We could check these in the project as well, but we can only do so if the project uses TypeScript. The checks for TypeScript are happening in #8, so we'd only be able to make that check once that ticket is closed. We can do that in another PR. - The GitHub workflow in module template runs tests against new commits pushed to the
mainbranch and commits pushed to pull requests, using thetestbuild script. We want to make sure that projects have this workflow too, but we can do that in a separate PR (either as a part of #6 or some other ticket). - At some point, we may consider changing the logic which checks conformance of
jest.config.jsso that project maintainers are allowed to tweak some of the options. For instance, some projects may not have 100% coverage, and may have to lower the coverage thresholds. We can figure this out in another PR, though.
desi
We want to make sure that for a given project:
jestandjest-it-upas dev dependencies, and the versions match the same dev dependencies as in the module templatejest.config.js, and the content of this file matches the same as in the module templatetestandtest:watchpackage scripts, and the values of these match the same package scripts as in the module template