MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Add `allow-scripts`-related checks #51

Closed mcmire closed 3 months ago

mcmire commented 5 months ago

We want to make sure that for a given project:

kanthesha commented 4 months ago

There are couple of validation, which seems unnecessary to me.

if the project has a .yarnrc file (Yarn Classic), then it has ignore-scripts true.

I read the why it is required! But once we say the project requires .yarnrc.yml and we need .yarnrc to be absent, then I don't see a point in further validating if there's a .yarnrc then it should have something!!

If the project has a .yarnrc file (Yarn Classic), then a "setup" package script should be present and should be equal to "yarn install && yarn allow-scripts".

Same as above. If we want user to not to have .yarnrc in their project, I don't see a point in if it exists it should have something!!