MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Automate module-lint report generation #60

Closed Gudahtt closed 2 months ago

Gudahtt commented 4 months ago

We want a module-lint report to be automatically generated and shared on a regular basis (e.g. maybe once every week or two?). This report should include a summary of how many rules are passing in each repository, and a link to further details about any errors that may exist. Ideally this report would be shared in Slack.

Acceptance criteria:

We may want to put this workflow in some other repository. It doesn't really matter where it lives though, this will be replaced by the dashboard eventually.

mcmire commented 3 months ago

A report summary is shared to Slack, which includes the percentage of rules passing for each repository

A question was raised in standup for how to show the number of passing and failing rules for each repo that was run.

The issue is all we're doing in the GitHub workflow is running the tool; once we do that we're not inside the tool anymore, and all we have to work with is the output of the tool.

There are a couple of ideas:

mcmire commented 3 months ago

@kanthesha What are your thoughts here? It seems like adding the concept of reporters would take a while to implement, so my vote is to hack this and parse the output manually as I described above. Note that we'd have to add a command-line option to disable colors — perhaps --no-color — but that should be fairly easy to add in comparison. Curious to know your thoughts. We may need an extra ticket to capture the work either way.

kanthesha commented 3 months ago

Sounds good to me to hack for now and create a separate ticket for reporters. If we are going to pick up the reporters ticket soon, then if we can just share the report link for now. I'm ok, either way.

kanthesha commented 2 months ago

The report summary part has been moved to new issue (#82).