MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Consider modifying `package-allow-scripts-yarn-conforms` to check Yarn Classic config file if Modern file does not exist #72

Open mcmire opened 3 months ago

mcmire commented 3 months ago

In the future, if a maintainer is running module-lint against a Yarn Classic project and they do not want to upgrade to Yarn Modern, they should be able to disable all of the Yarn-related rules (which are only concerned with Modern). However, if they do this but they have not disabled allow-scripts-related rules, then we still want module-lint to confirm that they've configured Yarn Classic to disable post-install scripts. However, currently, the package-allow-scripts-yarn-conforms rule only checks the Yarn Modern config file — it does not care about Yarn Classic. We may want to add a new version of this rule which checks the Yarn Classic config file.