search

MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Report error in case of module lint fails #75

Closed kanthesha closed 2 months ago

kanthesha commented 3 months ago

Now, when we run a yarn run-tool on a project, even when there're fails or even error, it is been resolved instead of throwing. Output in console now.

Screenshot 2024-03-27 at 14.35.43.png

We would like to throw an error.

Screenshot 2024-03-27 at 14.34.55.png
mcmire commented 3 months ago

For more context here, we need the tool to exit with a non-zero exit code if there are any lint errors or if the tool throws an error for any reason. This way, when running the tool in a GitHub workflow, the job will fail (as right now it would still show as running successfully, since we catch all errors).