MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Add checks for whether lint/formatting packages are present and up to date #9

Closed desi closed 7 months ago

desi commented 10 months ago

We want to make sure that for a given project:

At the time of writing, that would cover packages following the given pattern:

So, we'll want to first find dependencies in the module template that match these patterns, and then cross-reference then with the project.

We want to make sure we look for packages that follow these patterns and not specific packages, so that if we change them in the module template we don't have to update module-lint.

kanthesha commented 7 months ago

There're two cases which are not covered in the ticket description. Adding here for the tracking purpose.

  1. What happens when there're no lint dependencies in template's package.json?

    • For now, believing template project as a source of truth. The lint will pass if there're no lint dependencies exist in template. We can also throw error if there're no lint dependencies found! but it won't stop there, what about if there's no prettier or typescript/lint and so on.
  2. We haven't covered, what happens, if project package.json has lint dependencies which doesn't exist in template?