search

MetaMask / module-lint

Analyzes one or more repos for divergence from a template repo.
1 stars 3 forks source link

Use Slack threads to produce periodic report #91

Open mcmire opened 1 month ago

mcmire commented 1 month ago

Currently, the GitHub workflow that runs module-lint once a week posts each package's lint report in a separate Slack message. This works fine for now because there are only a few packages we are running module-lint against, but once we scale this up, it will create a lot of noise.

To combat this, this commit updates the workflow to produce a summary message and then post all of the per-package messages in a thread.

Testing

This workflow has been tested on a fork: https://github.com/mcmire/module-lint/actions/runs/9868378498

See an example of the Slack message this workflow produces: https://consensys.slack.com/archives/C06S195ANA0/p1720587196429879

References

Fixes #82.

Blocked by #90.

socket-security[bot] commented 1 week ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/core@1.10.1 environment, filesystem Transitive: network, unsafe +5 1.58 MB thboop

View full report↗︎

socket-security[bot] commented 1 week ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@actions/http-client@2.2.1, npm/@fastify/busboy@2.1.1, npm/tunnel@0.0.6, npm/undici@5.28.4

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

mcmire commented 1 week ago

@SocketSecurity ignore npm/tunnel@0.0.6 @SocketSecurity ignore npm/@fastify/busboy@2.1.1 @SocketSecurity ignore npm/@actions/http-client@2.2.1 @SocketSecurity ignore npm/undici@5.28.4

All of these make sense — actions/core needs to make HTTP requests to interact with an OIDC provider.