MetaMask / providers

An Ethereum Provider that connects over a stream, as injected into websites by MetaMask
MIT License
217 stars 123 forks source link

deps: Update to streams3 API #288

Closed legobeat closed 8 months ago

legobeat commented 8 months ago

Changed

The package is previously mixing usage of readable-stream@2, readable-stream@3 and Node.js native streams (the API and behavior of which differ depending on Node.js version). This consolidates all internal streams on portable readable-stream.

socket-security[bot] commented 8 months ago

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
extension-port-stream 2.1.1...3.0.0 None +2/-0 57 kB
json-rpc-middleware-stream 4.2.3...5.0.1 None +2/-6 67 kB gudahtt
@metamask/object-multiplex 1.3.0...2.0.0 None +2/-7 59.7 kB lgbot

🚮 Removed packages: @types/readable-stream@2.3.15

socket-security[bot] commented 8 months ago

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: extension-port-stream@3.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

legobeat commented 8 months ago
@SocketSecurity ignore extension-port-stream@3.0.0
jiexi commented 8 months ago

I mean, the tests pass. We probably want to test this locally in extension and see what happens. I imagine it'll just work though

jiexi commented 8 months ago

Tested locally. Seems to work fine