MetaMask / providers

An Ethereum Provider that connects over a stream, as injected into websites by MetaMask
MIT License
224 stars 124 forks source link

Remove deprecated properties, networkChanged event, and offline send() net_version support #306

Closed jiexi closed 6 months ago

jiexi commented 6 months ago

This PR removes properties that are not officially documented and should not have been exposed in the first place. It also removes support for the networkChange event and offline net_version resolution which will allow us to remove the last remaining chunk of networkId usage in Extension. These have all been properly deprecated, the most recent deprecations being 180 days old now.

Removes the following:

See: https://github.com/MetaMask/MetaMask-planning/issues/2195 See: https://github.com/MetaMask/metamask-improvement-proposals/discussions/23 See: https://github.com/MetaMask/MetaMask-planning/issues/2176 See: https://github.com/MetaMask/metamask-extension/pull/23375

Before

Screenshot 2024-03-07 at 10 16 08 AM

After

Screenshot 2024-03-07 at 10 23 54 AM

shanejonas commented 6 months ago

Total sidebar here but

Screenshot 2024-03-06 at 3 43 05 PM

null {id: undefined, jsonrpe: '2.0', result: '100'}

Wow looks like send doesnt generate an ID like how we have request set up. I do like that send leaves it up to the client to deal with the ID.