search

MetaMask / providers

An Ethereum Provider that connects over a stream, as injected into websites by MetaMask
MIT License
224 stars 124 forks source link

adding edge-chromium support for createExternalExtensionProvider #318

Open jhonnyV-V opened 5 months ago

jhonnyV-V commented 5 months ago

currently the Metamask stable extension ID is different in edge-chromium, this make the createExternalExtensionProvider function fail on edge, I just added a new field in the JSON with the correct ID and changed the way the ID is retrieved

This is my first pull request to any Metamask repo, and the changelog part was not clear to me, should I leave the changes under a version or under unreleased?.

Any feedback is helpful

legobeat commented 4 months ago

Thank you for your contribution @jhonnyV-V !

Looks good to me, guess we should test it too for good measure. I left some review suggestions to bring the meta-related stuff in line with expectations.

jhonnyV-V commented 4 months ago

Great, I accepted the suggestions, @legobeat

jhonnyV-V commented 1 week ago

Hi, @legobeat @mcmire any updates on this pr?