refactor: Use named `extension-port-stream` import for Vite compatibility

MetaMask / providers

An Ethereum Provider that connects over a stream, as injected into websites by MetaMask

MIT License

217 stars 123 forks source link

refactor: Use named `extension-port-stream` import for Vite compatibility #331

Closed zouhangwithsweet closed 2 weeks ago

zouhangwithsweet commented 2 weeks ago

fix vite import error in development
https://github.com/vitejs/vite/issues/9703

zouhangwithsweet commented 2 weeks ago

Reproduction

zouhangwithsweet commented 2 weeks ago

Can you help me with a code review? @legobeat

Mrtenz commented 2 weeks ago

Rather than handling it here, what do you think about fixing this upstream, i.e., removing the default export from extension-port-stream?

cc @legobeat

zouhangwithsweet commented 2 weeks ago

extension-port-stream?

Souds great. I just add the pr: https://github.com/MetaMask/extension-port-stream/pull/57

rekmarks commented 2 weeks ago

Once this version of extension-port-stream is released, it should be added here and the default export of PortDuplexStream should be replaced with the named export.

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/extension-port-stream@4.1.0	None	`0`	0 B

🚮 Removed packages: npm/extension-port-stream@3.0.0

View full report↗︎