search

MetaMask / rpc-cap

A module for adding an object-capabilities system to any JSON-RPC API as middleware for json-rpc-engine
ISC License
31 stars 32 forks source link

feat: add filterResponse deep compare with fast-deep-equal #119

Closed shanejonas closed 3 years ago

Gudahtt commented 3 years ago

@shanejonas Could you explain what this change is, and why it's being made?

shanejonas commented 3 years ago

Sure, this change extends the current filterResponse to support not just shallow arrays of strings, but deep compare of objects as well.

shanejonas commented 3 years ago

@rekmarks any reason why this was closed? continuing to support shallow strings only for filters doesn't sound like a long term solution?

rekmarks commented 3 years ago

Shoot, I just renamed the default branch and deleted master, forgetting that doing so closes open PRs 🤦‍♂️. Can you please reopen the PR against main? Sorry!