search

MetaMask / rpc-cap

A module for adding an object-capabilities system to any JSON-RPC API as middleware for json-rpc-engine
ISC License
31 stars 32 forks source link

fix mixed import/export #97

Closed brad-decker closed 4 years ago

brad-decker commented 4 years ago

adjusts types setup to correctly associate custom typing for third party library is-subsest

Fixes: #78

brad-decker commented 4 years ago

I would honestly create some distinction between third party types you're maintaining versus types you are shipping as part of your offering. We can move the is-subset folder into src/@types and set the typeRoots to point there. I guess I'm wondering if the is-subset types are shipped currently with the dist for rpc-cap?

rekmarks commented 4 years ago

@brad-decker, I see, that makes sense. Unfortunately, the existing types are shipped, although I sincerely doubt that anyone is using them.

Maybe we should take this opportunity to move all unnecessary types to a typings folder, may be more than just is-subset.

Edit: The other candidate would be gaba!

brad-decker commented 4 years ago

I'm fairly positive that rpc-cap isn't even using its own gaba.d.ts... its using the one in the gaba node_modules folder being shipped with gaba... as you'd want :)

rekmarks commented 4 years ago

Ah: #78

Might I suggest that you do whatever you see fit to clean up our types?