84 left applyConfig in something of a broken state. This PR fixes the behavior of applyConfig such that the config will transform argv, but only by setting properties that are valid arguments for the current command and that have not been specified by the user on the command line.
In addition, this PR makes the following changes:
Remove duplicate call to setSnapGlobals in yargs middleware
The duplicate call was added in #84 because applyConfig would overwrite arguments given on the command line, but this is no longer the case.
Stop parsing config options from package.json
We used the web3Wallet property in package.json to infer arguments to the CLI
This implicit, default behavior could be surprising. Let's just use explicit configs instead.
Use yarg's normalize config in builders for path arguments to normalize paths
sanitizeInputs now only converts ./ to ., which is not done by the yargs normalizer (which is just NodeJS.path.normalize(str)
Change deprecated required property in builders to demandOption
Remove some outdated aliases for the bundle option
Significant inline documentation is included via comments.
84 left
applyConfigin something of a broken state. This PR fixes the behavior ofapplyConfigsuch that the config will transformargv, but only by setting properties that are valid arguments for the current command and that have not been specified by the user on the command line.In addition, this PR makes the following changes:
setSnapGlobalsin yargs middlewareapplyConfigwould overwrite arguments given on the command line, but this is no longer the case.package.jsonweb3Walletproperty inpackage.jsonto infer arguments to the CLInormalizeconfig in builders for path arguments to normalize pathssanitizeInputsnow only converts./to., which is not done by the yargs normalizer (which is justNodeJS.path.normalize(str)requiredproperty in builders todemandOptionbundleoptionSignificant inline documentation is included via comments.