Closed khanti42 closed 1 month ago
Note :
915079
8bd00d
Diff files between the two :
package.json
packages/cardano-metamask-snap/images/icon.svg
packages/cardano-metamask-snap/package.json
packages/cardano-metamask-snap/snap.manifest.json
packages/cardano-metamask-snap/src/api/cardano__verifyAddress/index.test.ts
packages/site/src/hooks/useRequestSnap.ts
yarn.lock
Most of the changes are no-code change. Only a change in testing on the snap side and a change in the src of the companion dapp, diff is shown below:
diff --git a/packages/site/src/hooks/useRequestSnap.ts b/packages/site/src/hooks/useRequestSnap.ts
index a32623b..b35c9a3 100644
--- a/packages/site/src/hooks/useRequestSnap.ts
+++ b/packages/site/src/hooks/useRequestSnap.ts
@@ -25,12 +25,12 @@ export const useRequestSnap = (
const snaps = (await request({
method: 'wallet_requestSnaps',
params: {
- [snapId]: { version },
+ [snapId]: version ? { version } : {},
},
})) as Record<string, Snap>;
// Updates the `installedSnap` context variable since we just installed the Snap.
- setInstalledSnap(snaps[snapId] ?? null);
+ setInstalledSnap(snaps?.[snapId] ?? null);
};
return requestSnap;
Detail on the audit report :
The 2 low risk issues identified by the auditor have been corrected.
No Warning on Signing Arbitrary Data (ID SAY-01)
Floating Dependency Versions (ID SAY-02)
Checklist
All items in the list below needs to be satisfied.
No Warning on Signing Arbitrary Data
andFloating Version in package.json