MetaMask / snaps-registry

A registry containing metadata about verified and blocked Snaps.
Apache License 2.0
31 stars 16 forks source link

[New Snap] kobosu #910

Open khanti42 opened 1 week ago

khanti42 commented 1 week ago

Checklist

All items in the list below needs to be satisfied.

Audit

Auditor : Sayfer Link : https://sayfer.io/audits/metamask-snap-audit-report-for-doggyfi/

Security Assessment Findings:

  1. Fees Are Not Displayed to the User (ID: SAY-01)

    • Status: Fixed
    • Risk: Medium
    • Issue: Users were not shown the transaction fees upfront in the confirmation prompt, leading to a potential breach of trust.
    • Mitigation: Fees are now displayed separately in the initial prompt.
  2. Dependencies with Floating Versions (ID: SAY-02)

    • Status: Fixed
    • Risk: Low
    • Issue: Dependencies were not pinned to exact versions, increasing the risk of supply chain attacks.
    • Mitigation: Use of exact versions for all packages is recommended.
  3. Fee Data Not Displayed on Initial Prompt (ID: SAY-03)

    • Status: Acknowledged
    • Risk: Low
    • Issue: While fees are displayed, they only appear after the initial confirmation, which could lead to a poor UX as users might skip later prompts.
    • Mitigation: Fees should be presented in the first prompt.
  4. Development Leftovers (ID: SAY-04)

    • Status: Fixed
    • Risk: Informational
    • Issue: There were comments and unfinished features in the code that had been overlooked.
    • Mitigation: Ensure all known issues are resolved before production.
khanti42 commented 1 week ago

Production website not live yet : https://doggyfi.xyz/snap. Still demo : https://demo.doggyfi.xyz/snap. Waiting input from the team whether they want to proceed with demo website or if they can publish to production.