Abstract system-level permissions

MetaMask / snaps

Extend the functionality of MetaMask using Snaps

https://metamask.io/snaps/

Other

711 stars 546 forks source link

Abstract system-level permissions #2235

Open eriknson opened 4 months ago

eriknson commented 4 months ago

Some of our permissions might be too low-level for users to see during the installation phase.

Two things:

Potentially introduce another weight (5) to group these implicit permissions
Figure out where / how to show these in the UI (installation, settings, etc)

eriknson commented 3 months ago

Me and @FrederikBolding are thinking something along these lines: https://www.figma.com/file/Wlwk0cTx6PQkNhiX7vN13e/Snaps-Platform?type=design&node-id=1648%3A21759&mode=design&t=J5R8zcPzxjEqEYTf-1

eriknson commented 3 months ago

Basically, we abstract on the installation & update request if permission count > 3 we hide permissions with weight > 3

eriknson commented 3 months ago

No need to introduce another weight (5) for now. List of all permissions and their weights: https://www.notion.so/metamask-consensys/bac3299d2c5241c599d2e5e7986e72f7?v=ef742a61bd844435b7171bd2e90b447e

eriknson commented 3 months ago

Let's abstract permissions following these rules;

Installation: if permission count > 3 we hide permissions with weight > 3
Update ~& Permission request~: Always show requested and revoked permissions, and approved permissions with weight <= 2

danfinlay commented 2 months ago

“See all” doesn’t quite capture “we think this other stuff isn’t as dangerous”, imo.

david0xd commented 3 weeks ago

Given that we always have single permission displayed on Permission request screen, integration of abstraction will be skipped. We will revisit this part when Dynamic Permissions are integrated. At the moment, there are not enough permissions to apply and test the approach on the Permission request screen/flow.