Examples don't auto-bump dependencies when doing a new release

MetaMask / snaps

Extend the functionality of MetaMask using Snaps

https://metamask.io/snaps/

Other

720 stars 553 forks source link

Examples don't auto-bump dependencies when doing a new release #489

Closed FrederikBolding closed 2 years ago

FrederikBolding commented 2 years ago

When doing a new release we bump dependencies in each of the Yarn workspaces to match the newest versions of the other workspaces. This doesn't work for all examples and therefore results in CI failure, see: https://github.com/MetaMask/snaps-skunkworks/pull/487

rekmarks commented 2 years ago

@Mrtenz @FrederikBolding is this fixed? Please close if so.

FrederikBolding commented 2 years ago

@rekmarks I think we are waiting for a release!

FrederikBolding commented 2 years ago

Once the action is released we can bump it in skunkworks and fix the issue I believe. @Mrtenz correct me if I am wrong

rekmarks commented 2 years ago

This was on my plate this entire time, I had just forgotten it. action-create-release-pr@1.4.0 has been released, and since we target the v1 tag in this repo, that's what we'll be using now. This issue is resolved.