search

MetaMask / snaps

Extend the functionality of MetaMask using Snaps
https://metamask.io/snaps/
Other
712 stars 548 forks source link

Transaction Insights for token transactions #907

Open ritave opened 1 year ago

ritave commented 1 year ago

Discussed in https://github.com/MetaMask/snaps-monorepo/discussions/904

Originally posted by **highoak** November 3, 2022 I noticed that in token approve transaction there is no option to run snaps like any other transaction. Is it a bug or a feature? Is there any way to run it also in approve? ![image](https://user-images.githubusercontent.com/9609659/199720211-5e386942-1acd-4eff-b3bb-93379a5d97f6.png)
FrederikBolding commented 1 year ago

Any ideas how we can include transaction insights on approval screens that have a different layout than regular transactions? Same thing goes for NFT approvals. @GuillaumeRx @eriknson

GuillaumeRx commented 1 year ago

Any ideas how we can include transaction insights on approval screens that have a different layout than regular transactions? Same thing goes for NFT approvals. @GuillaumeRx @eriknson

I need to look at this confirmation screen code but IIRC we should just have to allow tx-insights to display on token approvals as we did for EOA transactions.

GuillaumeRx commented 1 year ago

After some research it seems like approvals use another screen. We should discuss with design on how to integrate insights to this screen. cc @eriknson

0xharold commented 1 year ago

Hi, has been there any progress with the approvals?

Montoya commented 1 year ago

Not yet @0xharold. It's in progress but will take a while.