MetaMask / test-dapp

The sample dapp used for e2e testing and metamask-extension QA
https://metamask.github.io/test-dapp/
MIT License
587 stars 347 forks source link

externally_connectable legacy API POC #317

Closed jiexi closed 4 months ago

jiexi commented 5 months ago

Meant to enable connecting to extension over externally_connectable.

See: https://github.com/MetaMask/MetaMask-planning/issues/2325 See: https://github.com/MetaMask/metamask-extension/pull/23920

socket-security[bot] commented 5 months ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/providers@16.0.0 Transitive: network +24 5.07 MB metamaskbot
npm/@scure/base@1.1.6 None 0 80.4 kB paulmillr
npm/abort-controller@3.0.0 None +1 265 kB mysticatea
npm/extension-port-stream@3.0.0 None 0 10.5 kB lgbot
npm/readable-stream@3.6.2 environment 0 124 kB matteo.collina
npm/webextension-polyfill@0.10.0 None 0 198 kB addons-robot

🚮 Removed packages: npm/readable-stream@3.6.0

View full report↗︎

socket-security[bot] commented 5 months ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Network access npm/micro-ftch@0.3.1
Network access npm/micro-ftch@0.3.1
Network access npm/micro-ftch@0.3.1
New author npm/extension-port-stream@3.0.0
New author npm/@metamask/safe-event-emitter@3.1.1

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/micro-ftch@0.3.1
  • @SocketSecurity ignore npm/extension-port-stream@3.0.0
  • @SocketSecurity ignore npm/@metamask/safe-event-emitter@3.1.1