MetaMask / test-dapp

The sample dapp used for e2e testing and metamask-extension QA
https://metamask.github.io/test-dapp/
MIT License
587 stars 347 forks source link

[MMSDK] Updates mmsdk to latest and fixes a bad call when extension doesn't exist #354

Closed christopherferreira9 closed 1 month ago

christopherferreira9 commented 1 month ago

Previously upon checking if the extension is present via EIP6963 the dapp would perform eth_accounts and sync chainId but when using the SDK this conflicts as a connection might not exist at that point. This avoids that empty call if extension is not installed and the SDK is used.

socket-security[bot] commented 1 month ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/sdk-communication-layer@0.27.0 environment 0 3.04 MB metamaskbot
npm/@metamask/sdk@0.27.0 None 0 29.4 MB metamaskbot

🚮 Removed packages: npm/@metamask/sdk-communication-layer@0.26.4, npm/@metamask/sdk@0.26.5

View full report↗︎