fix: catching invalid/unparsable transaction data

MetaMask / web3-provider-engine

A JavaScript library for composing Ethereum provider objects using middleware modules

MIT License

598 stars 327 forks source link

fix: catching invalid/unparsable transaction data #395

Closed martinheidegger closed 1 year ago

martinheidegger commented 2 years ago

The txData passed to create a transaction may not be valid and an error may be caused here. Instead of failing with an exception this commit returns the exception as error in the callback.

mcmire commented 1 year ago

Thank you for the pull request, but we are actively phasing out this package in favor of json-rpc-engine and its related packages, so I'm going to close this. As for the changes here, we no longer have this exact middleware in our pipeline. You may be able to find remnants of this code across @metamask/transaction-controller, @metamask/keyring-controller, @metamask/eth-keyring-controller, @metamask/eth-sig-util, and/or our products.