Additional CSS/JS for Render Setting is not included when there are no items

cliffparnitzky commented 4 years ago

Checklist before I submit this issue report

I confirm that:

[x] I have tested this with the latest version available
[x] I have read documentation @ http://metamodels.readthedocs.org/en/ or http://metamodels.readthedocs.org/de/
[x] I have checked the Contao community forums for references https://community.contao.org/
[x] I have checked existing issues for duplicates and found none @ https://github.com/MetaModels/core/issues?q=is%3Aissue

My environment is:

(Please fill in the actual values from your environment - check Contao Manager or use composer show)

Key	Value	Comments
PHP version:	7.3.21
Contao version:	4.4.51
MetaModels version:	2.1.9
Installed MetaModels packages:	-	variouse attributes
DCG version:	2.1.7

Issue description

Additional CSS/JS for Render Settings is not included in the backend when there are no items (empty list).

Steps to reproduce

Define some CSS for the backend list (e.g. to define the width of the filter selects)
Set the CSS file in the render setting
Open the list and use the search with a value that delivers no results

Describe the behaviour of the application

The additional defined CSS/JS for Render Setting is not included in the backend when there are no items (empty list).

Describe the expected behaviour of the application

The additional defined CSS/JS for Render Setting should also be included in the backend when there are no items (empty list).

Screenshots

At least 30 items ... the CSS for the filter is inclued

No items ... no CSS

zonky2 commented 4 years ago

thx

zonky2 commented 3 years ago

The CSS and Javascript is only for the items and not for the "environment". This is called in Item.php at parseValue. For the BE please use the conventional way...

https://de.contaowiki.org/Stylesheet_f%C3%BCr_Backend-Theme_erg%C3%A4nzen

cliffparnitzky commented 3 years ago

Yeah, you're right ... "i saw the wood not bevore the trees" ... That is the easiest solution. And if i have both, styling the items and the list view parts, I can put them into the same CSS file.

In my opinion, we have to describe this in the manual. This should be enough.

zonky2 commented 3 years ago

In my opinion, we have to describe this in the manual.

manual it´s OpenSource ;-)

zonky2 commented 3 years ago

done https://metamodels.readthedocs.io/de/latest/manual/component/rendersettings.html#optionen

MetaModels / core