search

MetaSys-LISBP / IsoCor

IsoCor: Isotope Correction for mass spectrometry labeling experiments
https://isocor.readthedocs.io
GNU General Public License v3.0
24 stars 9 forks source link

Update requirements.txt #36

Closed gmat closed 8 months ago

gmat commented 8 months ago

python > 3.12 compatibility
see issue #35

pierremillard commented 8 months ago

thanks @gmat , happy to see you around :)

I've solved the issue by switching from distutils to shutil (#37 ), let me know if you think importing setuptools is a better option.

gmat commented 7 months ago

I've solved the issue by switching from distutils to shutil (#37 ), let me know if you think importing setuptools is a better option.

I notice this option too but I was thinking you'll prefer the no code modification solution. Oups. Never mind. I'm not sure but this PR is not useful at all and its (could) add a new unused dependency to your software. :see_no_evil:

Maybe you should remove this on the next release version.

pierremillard commented 7 months ago

yes I've noticed that setuptools is not used, we'll remove it for the next release