fix: typos - Githubissues

MetabolicAtlas / data-files

Source data files used when deploying Metabolic Atlas

0 stars 0 forks source link

fix: typos #30

Closed inghylt closed 2 years ago

inghylt commented 2 years ago

Related issue(s) and PR(s)
This PR together with closes #1017

Type of change

[x] Other

List of changes made

Fixed typos

Screenshot of the fix

Testing

Rebuild and make sure /gems/repository works as expected

Further comments

Definition of Done checklist

[x] My code meets the Acceptance Criteria
[x] My code follows the NBIS style guidelines
[x] I have performed a self-review of my own code and commented any hard-to-understand areas
[x] Tests and lint/format validations are passing
[x] My changes generate no new warnings

MalinAhlberg commented 2 years ago

This is a bit unrelated to this PR, but would still be nice: run this file through prettier to increase readability.

inghylt commented 2 years ago

@MalinAhlberg Nice suggestion, implemented in fc7c1e02ea3e44c90141e6f99634cdd9fe0e1b36

mihai-sysbio commented 2 years ago

run this file through prettier to increase readability.

This increased the size of the uncompressed file by 10%, so the file was in "minified" like this on purpose, especially that it is not meant to be edited. Could you please make sure this size increase becomes irrelevant after compression, when served by Nginx?

inghylt commented 2 years ago

@mihai-sysbio Nice feedback! I have compared on dev and there seem to be no difference

Using data-files branch main

Using data-files current branch feat/fix-typos

mihai-sysbio commented 2 years ago

I have compared on dev and there seem to be no difference

Great, thank you! I trust the work and @MalinAhlberg's review, so I think this can be merged without further approvals.

edit: I was expecting, though, a much larger size difference between the uncompressed responses.