search

MetabolicAtlas / data-files

Source data files used when deploying Metabolic Atlas
0 stars 0 forks source link

feat: add custom maps for Yeast-GEM #5

Closed e0 closed 3 years ago

mihai-sysbio commented 3 years ago

The custom map that was planned to be added to this PR is supposed to be private for some more weeks. I'm proposing to leave this PR as is until then. What do you think @e0 ?

e0 commented 3 years ago

Sounds good! Do you want to leave the following related PRs pending as well?

From what I have tested there are no side-effects (except an extra warning message in the data generation code) so it should be safe to merge them. But I understand if we want to wait to merge everything at around the same time as well.

mihai-sysbio commented 3 years ago

Since the work is done, let's make the cards reflect that - I propose the merging of the other PRs, especially that they are safe to merge.

e0 commented 3 years ago

Since the work is done, let's make the cards reflect that - I propose the merging of the other PRs, especially that they are safe to merge.

There are some checklist items in the card and I have checked off all of them except "add the corresponding SVGs in data-files". Is there something else we should do to make it more obvious?

mihai-sysbio commented 3 years ago

I'm counting on us being pinged by the researcher whose custom map will be published to remind us about it. Together with a draft PR, I consider this an obvious enough reminder so I'm not inclined to create a Jira card.

mihai-sysbio commented 3 years ago

By chance, I found a commit that removed 6 custom maps for Yeast-GEM, which I think should now be added back. This would also enable us to close this PR.