search

MetabolicAtlas / data-generation

Process the raw data-files for ingestion into the Neo4j database
MIT License
0 stars 0 forks source link

feat: add support for custom SVG maps #12

Closed e0 closed 3 years ago

e0 commented 3 years ago

For testing locally, please use the https://github.com/MetabolicAtlas/data-files/tree/feat/custom-maps branch in the related data files repository.

e0 commented 3 years ago

@nanjiangshu Thanks for the review and feedback! I'm not sure if you saw but currently any custom maps should be listed in the sidebar to the left (list of maps). The section is between Compartment maps and Subsystem maps. The custom_map in the route is just a test name I have used for the map right now. I think the idea is that eventually there would be several different custom maps, which can be all accessed from the sidebar.

I do agree that we should still provide more ways to guide users to these custom maps. I think it would be best if we can make them in the maps available section in the gem browser pages. That may be out of the scope for the current task but I think we should add a new Jira task for exploring this in more depth.

nanjiangshu commented 3 years ago

@nanjiangshu Thanks for the review and feedback! I'm not sure if you saw but currently any custom maps should be listed in the sidebar to the left (list of maps). Sorry I overlooked it.

I do agree that we should still provide more ways to guide users to these custom maps. I think it would be best if we can make them in the maps available section in the gem browser pages. That may be out of the scope for the current task but I think we should add a new Jira task for exploring this in more depth.

I agree. For this issue I think the current implementation is good enough.