Closed kusalananda closed 1 year ago
It would be nice with a more descriptive PR name, also in the style of the conventional commits (style: ...
).
Any clue as to why the side-by-side diff shows everything has changed?
It would be nice with a more descriptive PR name, also in the style of the conventional commits (
style: ...
). Any clue as to why the side-by-side diff shows everything has changed?
PR title has been updated to be more descriptive.
I assume that a side-by-side diff would show that everything has changed if I managed to actually touch everything. If you want a breakdown of the changes with individual descriptions, these are found in the individual commits and their attached commit messages.
Is it convention to repeat the commit messages in the PR?
Is it convention to repeat the commit messages in the PR?
If there is only one commit in the PR, that's actually what GitHub does by default. To answer your question - not quite repeat, but summarize. That tends to yield a title closer to the issue title.
I went ahead and amended the issue body with a Testing section, please feel free to edit it.
Assuming the work in the issue has been completed, I've gone ahead and asked for reviews hoping that this PR can be merged in this sprint.
Mostly small style changes to the
generate
shell script.One of the changes, changing the names of the option used with
sort
, makes it run on systems with Busyboxsort
, e.g. Alpine Linux (this fixes #35).A summary of changes:
Testing