Use identifiers.js as single source of truth

MetabolicAtlas / data-generation

Process the raw data-files for ingestion into the Neo4j database

MIT License

0 stars 0 forks source link

Use identifiers.js as single source of truth #36

Closed jonandernovella closed 1 year ago

jonandernovella commented 1 year ago

Related issue(s) and PR(s)
This PR contributes to https://github.com/MetabolicAtlas/MetabolicAtlas/issues/1038

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Other

List of changes made

Merged two files and used better names for the objects

mihai-sysbio commented 1 year ago

@jon could you please use the conventional commits conventions as mentioned in the NBIS Development Guidelines (screenshot below):

perjo commented 1 year ago

Looks good and tested together with https://github.com/MetabolicAtlas/MetabolicAtlas/pull/1306 without errors.

jonandernovella commented 1 year ago

@jon could you please use the conventional commits conventions as mentioned in the NBIS Development Guidelines (screenshot below):

These are simply tips. As we discussed earlier, developers are encouraged but never obliged to follow any rules regarding commit messages in my workplace.

mihai-sysbio commented 1 year ago

Further clarification with @kusalananda's help: the aim is "no repetition".