Open dalehenrich opened 9 years ago
Looks like some if not all(?) of the Metacello issues are being addressed in PR #361
@dalehenrich Sorry, it is not easy to have an up to date text version of the critics (the monkey was not able to check). It is still possible to get a pharo image and to run the critics browser on Metacello packages. You will see that a lot of warnings are related to cross-Smalltalk or different Pharo versions support (unimplemented messages, undeclared references). But there are some other valid ones.
So is passing the code critic a requirement ? You cannot take snapshot(s) of the window and get enough information for me to fix the issues?
Ah well, I have never used the code critic and before, so please give me the instructions for opening the window and getting the information so I can fix the problems ...
How will I tell which things must be fixed and which things are not critical?
Dale
On 12/08/2015 06:36 AM, demarey wrote:
@dalehenrich https://github.com/dalehenrich Sorry, it is not easy to have an up to date text version of the critics (the monkey was not able to check). It is still possible to get a pharo image and to run the critics browser on Metacello packages. You will see that a lot of warnings are related to cross-Smalltalk or different Pharo versions support (unimplemented messages, undeclared references). But there are some other valid ones.
— Reply to this email directly or view it on GitHub https://github.com/dalehenrich/metacello-work/issues/362#issuecomment-162900834.