Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

add Squeak 4.6 & 5.0 platform attributes and update Travis #364

Closed pdebruic closed 9 years ago

pdebruic commented 9 years ago

This is a copy of Tobias's fix to the defaulPlatformAttributes update for Squeak 4.6 & 5.0

I also added Pharo 4, Squeak 4.6 & 5.0 to the .travis.yml file

dalehenrich commented 9 years ago

@pdebruic looks like we're down to a builderCI issue?:

+case "$ST" in
+IMAGE_BASE_NAME=Squeak-5.0
+IMAGE_TARGET_NAME=Squeak-5.0
+case "$ST" in
+case "$ST" in
+mv Squeak-5.0.changes ../Squeak-5.0.changes
mv: cannot stat `Squeak-5.0.changes': No such file or directory
The command "./build_image.sh" failed and exited with 1 during .
pdebruic commented 9 years ago

@dalehenrich

Yeah I was looking at that and confusing myself. Then I realized you haven't merged the pull request in Builder CI which fixes Squeak 5.0. So do that and these two PRs of mine should fix themselves once you re-trigger them on Travis..

I think.

dalehenrich commented 9 years ago

... and I've just merged the Squeak5.0 addition to builderCI, so I will restart the two Squeak5.0 builds ...

pdebruic commented 9 years ago

@dalehenrich OK but I think we will need to fix #369 for these to fully pass.

also - Can you restart the build for pr #366 ?

dalehenrich commented 9 years ago

366 is restarted ...

On 08/24/2015 11:54 AM, Paul DeBruicker wrote:

@dalehenrich https://github.com/dalehenrich OK but I think we will need to fix #369 https://github.com/dalehenrich/metacello-work/issues/369 for these to fully pass.

also - Can you restart the build for pr #366 https://github.com/dalehenrich/metacello-work/pull/366 ?

— Reply to this email directly or view it on GitHub https://github.com/dalehenrich/metacello-work/pull/364#issuecomment-134338151.

dalehenrich commented 9 years ago

@pdebruic, yes we are down to #369 for Squeak 5.0, so if you fix that bug as part of this PR, the master branch will be ready for prime time ... #366 still seems to be having massive failures and I will need to look at things a bit closer

krono commented 9 years ago

nice!