search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

add the platform attributes for 4.6 and 5.0 (for Metacello Preview) #366

Closed pdebruic closed 9 years ago

pdebruic commented 9 years ago

issue #365

dalehenrich commented 9 years ago

It looks like the code for 1.0.0-beta.32.17 is no longer passing - these results do not include your changes ... I suspect tests have changed since then .. so I am seriously considering merging this without passing travis tests ... remind me why I thought that we needed to make these changes:)

pdebruic commented 9 years ago

After merging this change we will get a new SHA we can reference in the ConfigurationOfMetacelloPreview (which we will update then all over the place) to ensure that when someone using Squeak 4.6 or 5.0 runs an #ensureMetacello process they get a version of Metacello that knows about the platform attributes for Squeak 4.6 & 5.0.

I think its fine to merge because it only affects the platform attributes on Squeak, and the code worksforme.....

dalehenrich commented 9 years ago

Now I will start work on updating the Configuration ... open an issue for tracking

pdebruic commented 9 years ago

We started the configuration on Friday I think. I've got it on my laptop. I'll push it and make a PR.

dalehenrich commented 9 years ago

Whoops, I made the same edits earlier this afternoon: bda06bff03992bab0d1af428c2e26bc038e77f25 ... seeing lots of test failures on both yours and mine - I assume that the problem is that we're hitting github api rate limits running the tests ... I've been restarting my tests and I think they are passing ... so I'm going to nuke your test run and go with my edits since the tests are further along ...

pdebruic commented 9 years ago

Sounds good.

On Aug 24, 2015, at 7:02 PM, Dale Henrichs notifications@github.com wrote:

Whoops, I made the same edits earlier this afternoon: bda06bf ... seeing lots of test failures on both yours and mine - I assume that the problem is that we're hitting github api rate limits running the tests ... I've been restarting my tests and I think they are passing ... so I'm going to nuke your test run and go with my edits since the tests are further along ...

— Reply to this email directly or view it on GitHub.

krono commented 9 years ago

patiently waiting :)

pdebruic commented 9 years ago

@krono see the comment on issue #365 ...

dalehenrich commented 9 years ago

Sorry @krono, I've got a lot of things on my plate right now and if the tests all ran green it would be much easier for me to just press a merge button ... I have yet to see 4.6 and/or 5.0 pass on travis either ...

On 8/28/15 7:02 AM, Tobias Pape wrote:

/patiently waiting/ :)

— Reply to this email directly or view it on GitHub https://github.com/dalehenrich/metacello-work/pull/366#issuecomment-135782217.

krono commented 9 years ago

No problem :) I am still on vacation and hence quite unresponsive