search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

Issue #367: Git Private Repository Authentication #368

Closed seandenigris closed 6 years ago

seandenigris commented 9 years ago

Respect siteUsername: and sitePassword when downloading Zips. OT: Fix "Metacello-Platform" package pharo30 branch, which had incorrect meta-data incorrectly specifying the package name including the branch i.e. "Metacello-Platform.pharo30"

seandenigris commented 9 years ago

What needs to be done here?

dalehenrich commented 9 years ago

Given that there were a large number of test failures one step is to rerun the tests, but at the moment I am struggling with getting Squeak4.6 and Squeak5.0 added so I've prioritized doing that inform of this one ....

I haven't looked at all of the failing tests, so I don't know if there are additional issues or not ... the load failures are due to network failures and rerunning should show whether or there are actual code-based problems ...

dalehenrich commented 9 years ago

@seandenigris, when you get a chance can you make a minor change to a file (like add a line to the README.md)? I'm getting massive failures for tests and I'm not sure whether travis is just confused or something else is going on ... "pinging travis" will at least eliminate travis is confused ...

davelab6 commented 8 years ago

I guess this should be closed

dalehenrich commented 6 years ago

Closing this PR - storing username/passwords in the image is not a good idea. the discussion in Issue #475 addresses the larger issue of enabling "first class access" to private repositories that require usernames and passwords ...