search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

MCGitHubRepository cacheDirectory not honored #407

Closed marianopeck closed 8 years ago

marianopeck commented 8 years ago

Looks like there is a setting for Pharo:

MCGitHubRepository cacheDirectory: '/Users/mariano/Pharo/localRepo/' asFileReference.

But seems ignored when I load something from github. In my example, from ConfigurationOfMyAPP, I am defining:

    spec baseline: 'OSSubprocess' with: [
        spec repository: 'github://marianopeck/OSSubprocess:master/repository' ].

But even with that, the zip ends up in the directory where the .image is.

dalehenrich commented 8 years ago

The.zip file is supposed to be downloaded into /tmp (see Issue #405 and #406) the cacheDirectory only controls the location of the actual unzipped filetree cache ... presumably the unzipped filetree is put into the cache directory?

marianopeck commented 8 years ago

OK, I understand now. So then it seems my issue is then #405 ?

dalehenrich commented 8 years ago

Yes ... as long as the unzipped filetree is going to the right place ...

Dale

On 07/22/2016 12:15 PM, marianopeck wrote:

OK, I understand now. So then it seems my issue is then #405 https://github.com/dalehenrich/metacello-work/issues/405 ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dalehenrich/metacello-work/issues/407#issuecomment-234631477, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmFT0NEzLwYJSgBJn45kZ0UXwBpBvGyks5qYRbYgaJpZM4JTC6f.

marianopeck commented 8 years ago

Yes, those seem to be going to the correct place :)

dalehenrich commented 8 years ago

ah, good!