search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

MetaceloPackageSpec workingCopyNameFor call name which could lead to … #447

Closed jecisc closed 7 years ago

jecisc commented 7 years ago

…deprecation warning when current version is array in Pharo

Related issue: https://github.com/dalehenrich/metacello-work/issues/446

dalehenrich commented 7 years ago

I am afraid that not getting back a versionInfo from Pharo could cause additional problems ... specifically I am suspicious that MetacelloToolBox>>updateVersionSpec:fullVersionSpec:updateProjects:updatePackages:visited:updated: will fail ... with that said, I think that this code is only used when using a ConfigurationOf and doing an update, so perhaps with the move towards github based projects this won't be a long term issue ...

dalehenrich commented 7 years ago

@jecisc, @estebanlm fixed this particular bug in PR #448 in a slightly different fashion, along with a set of other issues ...

jecisc commented 7 years ago

Cool :)