search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
88 stars 43 forks source link

Correct problem with file deletion on windows #488

Closed jecisc closed 6 years ago

jecisc commented 6 years ago

Close the archive before deleting it in MCGitBasedNetworkRepository class>>projectDirectoryFrom:version:

Also, there is a small cleaning of the code.

Fixes https://github.com/Metacello/metacello/issues/484

jecisc commented 6 years ago

Anyone to merge?

dalehenrich commented 6 years ago

@jecisc Does the fact that the test fails in Pharo-6.1 have an impact on your desire to merge?

jecisc commented 6 years ago

I don't think the failing job is related to this PR because the error is related to the loading of Metacello and this PR touch nothing from the baseline.

Loaded -> ConfigurationOfExternal-DaleHenrichs.1340411684 --- https://github.com/dalehenrich/external.git[d919497] --- /home/travis/smalltalkCI-master/_builds/pharo-local/iceberg/dalehenrich/external/repository (Libgit)
Project: External 0.9.0
Project: External
...RETRY->BaselineOfExternal
...RETRY->BaselineOfExternal
...FAILED->BaselineOfExternal/home/travis/smalltalkCI-master/_cache/vms/Pharo-6.1/pharo: line 11:  5085 Trace/breakpoint trap   (core dumped) "$DIR"/"pharo-vm/pharo" --nodisplay "$@"

Also, it's failing on the other PR I made.