search

Metacello / metacello

Metacello is a package management system for Smalltalk
MIT License
87 stars 43 forks source link

Honor possible case-insensitivity of certain file system repositories #542

Closed LinqLover closed 2 years ago

LinqLover commented 3 years ago

For instance, paths are not case-sensitive on Windows. The same applies to BitBucket or GitHub repositories. For a recent real-world failure caused by this inconsistency, see: https://github.com/hpi-swa-lab/SqueakByExample-english/pull/105/commits/f9beaad90e843a3ed68c6e69a118eefd857bf2a8

LinqLover commented 3 years ago

@dalehenrich Do you know whether we already have tests for the conflict behavior? If yes, I would add a short test case for this bug. Otherwise, I don't think it's worth bigger efforts.

LinqLover commented 3 years ago

@dalehenrich Could you maybe refine the list of expected failures on CI at some time? It's pretty hard for occasional contributors like me to find out whether I actually broke something or whether not. :-)

LinqLover commented 3 years ago

@dalehenrich It would still be great if you had some time to look at this PR. :-)

dalehenrich commented 3 years ago

Sorry, I didn't realize that I was directly named ... I'l try to find some time in the next few days to see what's up here ...

dalehenrich commented 3 years ago

ah ... travis-ci no longer supports open source projects, so the ci jobs must be ported to github actions ... I've done this for metacello-work and the ci tests are all passing ... so with the exception of the slack notification the ci.yml file should move over pretty much unchanged ... I'll try to make some time to do that tomorrow ...

dalehenrich commented 3 years ago

@LinqLover with PR #549. this project is using github actions for CI ... I left the pharo projects off of the list (I think that they have their own fork of Metacello) and I took GemStone off of the list, because I did a bit of hack job to work around a set of tests that recently started failing for GemStone - without the hack or an actual fix all of the GemStone runs fail, so it is more expedient to remove GemStone than wait for me to "do the right thing" ...

I'm not exactly sure how to get an open PR to start using github actions, although recreating the PR should do the trick ...

LinqLover commented 3 years ago

Thank you!

I'm not exactly sure how to get an open PR to start using github actions, although recreating the PR should do the trick ...

Just by merging master with the new .yml file into this branch, which I did right now. Let's see whether the CI passes now. :-)

LinqLover commented 2 years ago

Hey @dalehenrich, do you think we could merge this PR finally? :-)

LinqLover commented 2 years ago

Perfect! :-)

dalehenrich commented 2 years ago

Unless I'm mistaken, you have permissions to merge pull requests ... if not I will bump your permissions so that you can push the button ...

dalehenrich commented 2 years ago

I trust you ...

LinqLover commented 2 years ago

Yes, I could have merged it myself. But another pair of eyes is always a good idea, I guess. 😅

dalehenrich commented 2 years ago

Ah ... I am willing to review code on demand :)