MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.
MIT License
1.87k stars 845 forks source link

Parsing the output parser need Network as input #1036

Closed NicolasDorier closed 3 years ago

NicolasDorier commented 3 years ago

Ping @joemphilips I am changing your implementation to be able to pass the network for parsing. Else you have perf issues, strange behaviors, and it will break with shitcoins.

If you feel motivated for taproot soon... :D

I noticed the issue, since for the new release of NBitcoin, I do not allow parsing of any base58 data without passing the Network.

This code is really black magic for me, I don't know how to debug it nor the logic, I only know it works well.