search

MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.
MIT License
1.86k stars 844 forks source link

Method `PubKey.GetSegwitAddress` removed without marking obsolete #1068

Closed su8898 closed 2 years ago

su8898 commented 2 years ago

Public method PubKey.GetSegwitAddress was removed in commit https://github.com/MetacoSA/NBitcoin/commit/364677b9f5603950a189b3e5e257f123135b59f2 but it was not marked as obsolete in any of the previous versions. Do we have any other alternatives?

Thanks

NicolasDorier commented 2 years ago

Yes, Pubkey.GetAddress(ScriptPubKeyType.Segwit, Network.Main) I should have been more careful put it obsolete for a while.

knocte commented 2 years ago

And BitcoinAddress.GetScriptAddress() has also disappeared?

NicolasDorier commented 2 years ago

Yeah, I don't even remember what this one did.

knocte commented 2 years ago

We finally migrated to 6.x in this commit: https://github.com/nblockchain/geewallet/commit/a16ef649386e59f5f3c3da25933ba5ed6e198886 . This issue can be closed.