Enhance PayToTaprootTemplate

onvej-sl commented 2 years ago

This PR makes some enhancement in PayToTaprootTemplate:

It deprecates ~~GenerateScriptPubKey~~GenerateScriptSig in favour of GenerateWitScript. Rationale: A taproot output is a version one segwit output (see BIP-341). That means its scriptSig is empty and its redeem script (Schnorr signature) is placed in witness. The function GenerateScriptPubKey remains present in the code to ensure backward compatibility.
It implements support of annex (see BIP-341).
It implements ExtractWitScriptParameters.
It introduces tests of PayToTaprootTemplate.

yahiheb commented 2 years ago

It depracetes GenerateScriptPubKey in favour of GenerateWitScript.

It depracetes GenerateScriptSig.

NicolasDorier commented 2 years ago

Awesome, will merge that tomorrow after reviewing.

onvej-sl commented 2 years ago

In https://github.com/MetacoSA/NBitcoin/pull/1082/commits/ca008dae959b34bcb791459c77f173c863a076da I swap bodies of the functions GenerateScriptSig(TaprootSignature signature) and GenerateWitScript(TaprootSignature signature), so the obsolete function GenerateScriptSig(TaprootSignature signature) can be easily removed once you decide to do that.

MetacoSA / NBitcoin