support taproot OutputDescriptor

MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.

MIT License

1.86k stars 840 forks source link

support taproot OutputDescriptor #1141

Closed joemphilips closed 6 months ago

joemphilips commented 1 year ago

Not ready for review yet.

joemphilips commented 1 year ago

Ready for review. Two things to note.

I'm planning to add some tests. Since some basic tests for descriptor with tapscript are missing in bitcoind side, I should probably create a PR to bitcoind first.
it does not support signing/spending from taproot. Since TransactionBuilder does not support tapscript yet.

NicolasDorier commented 1 year ago

I only saw that now, will look closer to this. I don't really like the new members in ScriptPubKeyType. Those values should represent how an address can be derived directly from a pubkey. (ouside TaprootRaw if I understand) The new values don't have enough information to derive from pubkey.

lontivero commented 6 months ago

Is there something that I can do to help making this PR into NBitcoin?

lontivero commented 6 months ago

NicolasDorier commented 6 months ago

@lontivero you didn't pinged me enough :p