MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.
MIT License
1.87k stars 846 forks source link

Too small max transaction size #1158

Open kvpbldsck opened 1 year ago

kvpbldsck commented 1 year ago

Seems like bitcoin currently support transaction with size up to 400_000 (https://github.com/bitcoin/bitcoin/blob/master/src/policy/policy.h, line 27), but NBitcoin have limit of 100_000 (https://github.com/MetacoSA/NBitcoin/blob/master/NBitcoin/TransactionBuilder.cs line 2685). Would be great to increase limit.

contributeless commented 1 year ago

+1

huguojunsy commented 1 year ago

+1

zapilich commented 6 months ago

+1

knocte commented 6 months ago

Propose a PR?

lontivero commented 6 months ago

You are comparing weights with vsized, they are not the same.