search

MetacoSA / NBitcoin

Comprehensive Bitcoin library for the .NET framework.
MIT License
1.85k stars 839 forks source link

Replaced custom parsing logic by Uri #1169

Closed YohDeadfall closed 1 year ago

YohDeadfall commented 1 year ago

@lontivero, that pull request replaces the current custom logic I asked you about with one provided by Uri out of the box.

Note that the pull request changes the type of an exception to be thrown by BitcoinUriBuilder from FormatException to UriFormatException. Still, it should be safe since the last one derives from FormatException.

knocte commented 1 year ago

ACK

knocte commented 1 year ago

ACK

FTR, my ACK was a false positive, I thought I was commenting on this other PR: https://github.com/MetacoSA/NBitcoin/pull/1168